Code Review
Review behavior before style.
Passes
- Intent: does the change match the stated problem and scope?
- Correctness: invariants, boundaries, state transitions, error paths, concurrency.
- Security/privacy: trust boundaries, authorization, injection, secret and personal-data handling.
- Operations: migrations, compatibility, observability, rollout, rollback.
- Tests: meaningful behavior, negative cases, determinism, missing regression coverage.
- Maintainability: naming, duplication, coupling, complexity, documentation.
Useful finding format
[Severity] Short title — file:line
Scenario: what conditions trigger the issue?
Impact: what fails or becomes unsafe?
Correction: smallest practical change.Avoid vague preferences and speculative concerns without a concrete failure scenario.